Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): templating arguments getops #2280

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joshuachp
Copy link

Description

  • Source branch in your fork has meaningful name (not main)

Fixes Issue:

The templating CLI parameter requires an argument for the template to use, but this cannot be passed since the getops definition is missing the = sign.

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

The `templating` CLI parameter requires an argument for the template to use, but this cannot be passed since the `getops` definition is missing the `=` sign.
@joshuachp joshuachp closed this Jun 17, 2024
@joshuachp joshuachp deleted the fix/cli-templating branch June 17, 2024 18:25
@joshuachp joshuachp restored the fix/cli-templating branch June 17, 2024 18:28
@joshuachp
Copy link
Author

I'm not sure if this is applicable since the python version doesn't support HTML. Reopening anyway

@joshuachp joshuachp reopened this Jun 17, 2024
@bitwiseman
Copy link
Member

templating also exists in the javascript beautifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants